Update to FSRS #41
Merged
Update to FSRS #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
h16nning
commented
Feb 9, 2024
h16nning
commented
- Implemented FSRS (using fsrs.js). Several UI components had to be updated to comply with the new model.
- Removed old SpacedRepetition (based on SM2)
- Updated learn.ts, LearnView, LearnViewHeader and LearnViewFooter and more to use the new algorithm
- Rewrote short-term scheduling in learn.ts. The code is a little shorter now and hopefully more readable. Despite some basic manual testing the new short-term algorithm may contain some more bugs. I'll fix them as I find them.
- Option to sort how cards appear in LearnView (no UI yet), for now sort by creation date and alphabet.
- Added RemainingCardsIndicator back to the UI (shows how many cards of which type are left). Its design is pretty rough right now and only temporary.
Might be still buggy or have placeholder values, not everything tested yet temporary ui to debug
Sort types: for now byCreationDate and bySortField (using displayPreview from CardTypeManager)
- fixed repetition accuracy and repetition numbers - fixed isFinished being set to true if there is still a card but react state hasn't updated yet (current solution: isFinished is being set to false again, but it is fast enough to not be visible) - fixed DeckPreview showing always one as to review count
- Removed DebugCardTable from always showing in LearnView - fixed stopwatch - fixed ProgressBar for learnAll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.